• beardedrhino
    link
    fedilink
    52 years ago

    What am I looking at here? It just always goes to the first case right? 🤔

    • fsniperOP
      link
      fedilink
      -12 years ago

      It’s not the real issue. I introduced that while anonymizing the data. It’s that a 3-5 liner code became a huge switch case by just incrementing the code and never thinking how it should be done. This was caused by like 15 engineers in time :)

      Something like below would be huge improvement:

      subs1 = ["cluster1", "cluster2"]
      if subs1.contains(clusterName) return subs1
      
      
    • fsniperOP
      link
      fedilink
      42 years ago

      And no reason to state this is from production.

  • fsniperOP
    link
    fedilink
    32 years ago

    no one looks behind and questions how and why.

      • fsniperOP
        link
        fedilink
        12 years ago

        It is, but If you review 3 lines of pr and not the whole 50 lines of the file without thinking of the overall picture, this happens. I got this while reviewing a pr like this. And most probably I approved similar prs for this file in the past. Shame on me too…